Comments on: Broken == in MongoMapper http://djwonk.com/blog/2009/10/21/broken-equality-in-mongomapper/ software development + public policy Thu, 10 Dec 2009 19:25:40 +0000 http://wordpress.org/?v=2.9 hourly 1 By: David http://djwonk.com/blog/2009/10/21/broken-equality-in-mongomapper/comment-page-1/#comment-226 David Wed, 21 Oct 2009 22:58:41 +0000 http://djwonk.com/blog/?p=186#comment-226 Dan: Whoops! I fixed the typo. DataMapper behaves like I would expect, thanks! Dan: Whoops! I fixed the typo. DataMapper behaves like I would expect, thanks!

]]> By: Dan Kubb http://djwonk.com/blog/2009/10/21/broken-equality-in-mongomapper/comment-page-1/#comment-225 Dan Kubb Wed, 21 Oct 2009 22:53:19 +0000 http://djwonk.com/blog/?p=186#comment-225 I just checked the DataMapper example above, and the last statement returns false with the edge DM. Script to reproduce: http://gist.github.com/215552 I just checked the DataMapper example above, and the last statement returns false with the edge DM.

Script to reproduce: http://gist.github.com/215552

]]> By: Dan Kubb http://djwonk.com/blog/2009/10/21/broken-equality-in-mongomapper/comment-page-1/#comment-224 Dan Kubb Wed, 21 Oct 2009 22:25:53 +0000 http://djwonk.com/blog/?p=186#comment-224 FWIW, I agree with you in the above case. In DataMapper we decided that by default objects should be compared based on their public attributes values, not internal bookkeeping values. This is true even in cases where the two objects may refer to the same record in the datastore. Here's a link to the relevant specs we have: http://bit.ly/4cE7EZ Although I wouldn't say the conversation is spiraling out of control. It appears to be reasonably civil, but I understand how it could appear that way when you have a strong opinion of how something should work. I've certainly been involved in discussions that didn't feel good at the time, but looking back they weren't that bad.. in reality these types of discussions are good for the community because it gets people to pay attention to the details. FWIW, I agree with you in the above case.

In DataMapper we decided that by default objects should be compared based on their public attributes values, not internal bookkeeping values. This is true even in cases where the two objects may refer to the same record in the datastore.

Here’s a link to the relevant specs we have: http://bit.ly/4cE7EZ

Although I wouldn’t say the conversation is spiraling out of control. It appears to be reasonably civil, but I understand how it could appear that way when you have a strong opinion of how something should work. I’ve certainly been involved in discussions that didn’t feel good at the time, but looking back they weren’t that bad.. in reality these types of discussions are good for the community because it gets people to pay attention to the details.

]]>